Skip to content

Studio: Update Studio scheme protocol handler to AppxManifest for Windows #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Studio: Update Studio scheme protocol handler to AppxManifest for Windows #2040

wants to merge 2 commits into from

Conversation

@gavande1
Copy link
Contributor

@gavande1 gavande1 commented Nov 7, 2025 •
edited
Loading

Related issues

Proposed Changes

  • Update Studio protocol from from wpcom-local-dev to wp-studio to the existing app manifest

Testing Instructions

Taken from #1969, Props to @bcotrim

  1. Download the signed .appx file from the CI build artifacts for this PR
  2. Install the .appx on a Windows machine (right click -> Install)
  3. Open Studio and click the "Login" button in the top right
  4. Authenticate in the browser when redirected to WordPress.com
  5. After approving, verify the browser shows "Authorized. You can now open Studio and close this window."
  6. Verify Studio successfully logs you in and displays your account information

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@gavande1 gavande1 changed the title Update protocol handler name in appx packaging script from 'wpcom-loc… Studio: Update Studio scheme protocol handler to AppxManifest for Windows Nov 7, 2025
@gavande1
Copy link
Contributor Author

gavande1 commented Nov 7, 2025

This needs to be deployed after #2029 is deployed.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

📊 Performance Test Results

Comparing 4d7bee2 vs trunk

site-editor

Metric trunk 4d7bee2 Diff Change
load 12521.00 ms 10421.00 ms -2100.00 ms 🟢 -16.8%

site-startup

Metric trunk 4d7bee2 Diff Change
siteCreation 27206.00 ms 25536.00 ms -1670.00 ms 🟢 -6.1%
siteStartup 10037.00 ms 8022.00 ms -2015.00 ms 🟢 -20.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

gavande1
gavande1 commented Nov 7, 2025
View reviewed changes
common/constants.ts
// OAuth constants
export const CLIENT_ID = '95109';
export const PROTOCOL_PREFIX = 'wpcom-local-dev';
export const PROTOCOL_PREFIX = 'wp-studio';
Copy link
Contributor Author

@gavande1 gavande1 Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary change until #2029 is merged.

@gavande1 gavande1 self-assigned this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gavande1 gavande1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavande1